invalid sample names from big files found on mds3 init is reported to… #2541
+126
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzhou82
force-pushed
the
issue.2540
branch
3 times, most recently
from
b5e682d to
2790c5e
Compare
xzhou82
force-pushed
the
issue.2540
branch
2 times, most recently
from
4933102 to
f4efc7d
Compare
xzhou82
commented
Jan 9, 2025
| */ | ||
| type SnvindelComputeGroup_filter = { | ||
| // FIXME type value can only be 'filter' but breaks tsc | ||
| type: string //'filter' |
There was a problem hiding this comment.
@creilly8 here supplying type:'filter' will cause npx tsc error (run this command in sjpp/ and checkout pp.issue.2513_newInput branch to get corresponding sjlife ds file changes)
could u take a look?
There was a problem hiding this comment.
Looks like the type: 'filter' isn't compatible with the other type attributes as string. We saw a similar issue with non-overlapping attributes in unions typing the geneVariant termsetting code.
gavrielm
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… console log
Description
closes #2540
contains misc fixes related to survivorship db rebuild
all CI pass. is not dependent on sjpp PR and can test with sjpp master
Checklist
Check each task that has been performed or verified to be not applicable.